Refactor Spring AI Bedrock options #1940
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor the options builder methods to remove `with` as the suffix - Update all the models under spring-ai-bedrock - Deprecate the existing methods - Update references and docs
ilayaperumalg
force-pushed
the
refactor-bedrock-options
branch
from
b67a74f to
c82ce2e
Compare
markpollack
reviewed
Dec 17, 2024
| .withTopP(0.9) | ||
| .withMaxTokens(100) | ||
| .build()); | ||
| this(chatApi, BedrockAi21Jurassic2ChatOptions.builder().temperature(0.8).topP(0.9).maxTokens(100).build()); |
Member
There was a problem hiding this comment.
should validate this is the same set of defaults as with autoconfig
markpollack
reviewed
Dec 17, 2024
|
|
||
| public BedrockLlamaChatModel(LlamaChatBedrockApi chatApi) { | ||
| this(chatApi, BedrockLlamaChatOptions.builder().withTemperature(0.8).withTopP(0.9).withMaxGenLen(100).build()); | ||
| this(chatApi, BedrockLlamaChatOptions.builder().temperature(0.8).topP(0.9).maxGenLen(100).build()); |
Member
There was a problem hiding this comment.
check for consistency with autoconfig defaults.
Member
|
merged in 65e7a1d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the options builder methods to remove
withas the suffixDeprecate the existing methods