-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(redis): Implement ChatMemoryRepository interface and fix test connectivity #2991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fa30ff5 to
c894ab9
Compare
|
@markpollack I am almost there with a modularized version of the PR... a few more hours |
…nectivity Refactor Redis-based chat memory implementation to: - Implement ChatMemoryRepository interface as requested in PR spring-projects#2295 - Fix Redis connection issues in integration tests reported in PR spring-projects#2982 - Optimize conversation ID lookup with server-side deduplication - Add configurable result limits to avoid Redis cursor size limitations - Implement robust fallback mechanism for query failures - Enhance support for metadata, toolcalls, and media in messages - Add comprehensive test coverage with reliable Redis connections Signed-off-by: Brian Sam-Bodden <[email protected]>
Signed-off-by: Brian Sam-Bodden <[email protected]>
f25252d to
e75d16a
Compare
|
@markpollack I think I got everything in place now. Let me know if I need to do anything else to get this going. Cheers! |
I am looking forward to this feature(semantic cache). When will it be available🫡? |
|
Hey all, this feature is a great win. Wondering when this is planned to be released? Would appreciate the chance to use Redis as my short term storage solution! |
|
@markpollack Hey, does this mean that SpringAI will not be moving forward with a Redis impl for chat memory? |
|
Hi. I think I closed this newer PR by mistake, keeping the older one open. I'll close #2295 and reopen this one |
|
I can't seem to set the status of the PR to open again, it seems you need to do it @bsbodden |
|
i'll be making a new PR that is compatible with the current code base structure, will link once it is posted. |
@markpollack I can't seem to be able to re-open the PR. I'll try a force push to see if that "wakes it up" :-) |
|
@markpollack I pushed it as a new PR here #4982 |
@markpollack cc/ @joshlong @ThomasVitale @tzolov with the help of Josh I made some modifications requested for the new changes upstream and the issues with the TestContainers connectivity. I will follow up with an addition to break the functionality into separate modules and do some more clean up. But hopefully this PR will allow you to continue the review. Thanks!
Refactor Redis-based chat memory implementation to:
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commits