refactor(spring-ai-model): improve parameter name in ChatGenerationMetadata #3507
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ahoo-Wang
commented
Jun 11, 2025
Ahoo-Wang
commented
- Changed the parameter name in the finishReason method from 'id' to 'finishReason' for better clarity and accuracy
…tadata - Changed the parameter name in the finishReason method from 'id' to 'finishReason' for better clarity and accuracy Signed-off-by: Ahoo Wang <[email protected]>
sunyuhan1998
approved these changes
Jun 11, 2025
scionaltera
pushed a commit
to scionaltera/spring-ai
that referenced
this pull request
Sep 3, 2025
…tadata (spring-projects#3507) - Changed the parameter name in the finishReason method from 'id' to 'finishReason' for better clarity and accuracy Signed-off-by: Ahoo Wang <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
…tadata (spring-projects#3507) - Changed the parameter name in the finishReason method from 'id' to 'finishReason' for better clarity and accuracy Signed-off-by: Ahoo Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.