feat(zhipuai): Add Builder pattern for ZhiPuAiApi #3726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxsl-gr Could you help with the review please? Thanks! |
no problem |
mxsl-gr
reviewed
Jul 7, 2025
...ring-ai-zhipuai/src/test/java/org/springframework/ai/zhipuai/api/ZhiPuAiApiBuilderTests.java
Outdated
Show resolved
Hide resolved
- Added builder and mutate methods to construct ZhiPuAiApi instances - Use more fine-grained code formatter control - Allowed custom completionsPath and embeddingsPath - Existing constructor marked as Deprecated - Added WebClient.Builder parameter - Updated integration tests, using Builder pattern to construct ZhiPuAiApi - Added Builder unit test Signed-off-by: YunKui Lu <[email protected]>
mxsl-gr
approved these changes
Jul 8, 2025
|
@mxsl-gr Thanks for the code review! Hi @ilayaperumalg , can this PR be merged? I have some follow-up PRs related to Zhipu that may depend on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran all the updated integration tests locally