Skip to content

Conversation

@csbiy
Copy link
Contributor

@csbiy csbiy commented Aug 10, 2025

This PR removes unnecessary null checks from the StTemplateRenderer class to simplify the code and avoid redundant validation.

Changes

  • Removed redundant null checks on template variables map keys in the apply method.
  • Simplified validation logic by eliminating defensive checks that are unlikely to occur.

- Simplified code by dropping redundant null checks

Signed-off-by: csbiy <[email protected]>
Signed-off-by: csbiy <[email protected]>
Copy link
Contributor

@sunyuhan1998 sunyuhan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 28, 2025
@sobychacko sobychacko merged commit dc82e5d into spring-projects:main Aug 28, 2025
2 checks passed
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
…spring-projects#4104)

- Simplified code by dropping redundant null checks

Signed-off-by: csbiy <[email protected]>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
…spring-projects#4104)

- Simplified code by dropping redundant null checks

Signed-off-by: csbiy <[email protected]>
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
…spring-projects#4104)

- Simplified code by dropping redundant null checks

Signed-off-by: csbiy <[email protected]>
Signed-off-by: 家娃 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants