ProblemDetail is rendered to XML incorrectly #48222
Open
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ProblemDetailXmlMapperBuilderCustomizer applied the wrong ProblemDetail mixin for the Jackson XmlMapper. Namely the ProblemDetailJacksonMixin, which is intended for JSON. Now the ProblemDetailJacksonXmlMixin is used instead. The corresponding test also tested for the wrong XML output, which has been adjusted. Signed-off-by: Maurice Zeijen <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: bug
wilkinsona
added
type: regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
ProblemDetailXmlMapperBuilderCustomizerincorrectly applies theProblemDetailJacksonMixin(intended for JSON) to the JacksonXmlMapper.Builder. It now correctly applies theProblemDetailJacksonXmlMixinfor proper XML serialization.Previously, with the wrong mixin, Jackson produced XML like this:
<ProblemDetail><status>404</status><title>Not Found</title><spring>boot</spring></ProblemDetail>After applying the correct mixin, the output matches the expected format as defined in RFC 7807, Appendix A:
<problem xmlns=\"urn:ietf:rfc:7807\"><status>404</status><title>Not Found</title><spring>boot</spring></problem>This format includes the correct root element (
problem) and namespace declaration, consistent with Spring Boot 3.x output.The related test has been updated accordingly to verify the correct XML output.