Skip to content

Drop old 'jakarta_omit' option #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025

Conversation

breun
Copy link
Contributor

@breun breun commented Jul 6, 2025

The jakarta_option was only supported by a single grpc-java release and quickly replaced by @generated=omit (grpc/grpc-java#11086), which is already used by the sample configurations.

The 'jakarta_option' was only supported by a single grpc-java release and quickly replaced by '@generated=omit'

Signed-off-by: Nils Breunese <[email protected]>
@onobc
Copy link
Contributor

onobc commented Jul 6, 2025

Something else we need to be aware of if this change get approved, the generation of the option in start.spring.io (details)

@dsyer
Copy link
Member

dsyer commented Jul 6, 2025

Probably this change can be made independently though?

@dsyer dsyer merged commit 08ffc32 into spring-projects:main Jul 6, 2025
5 checks passed
@breun breun deleted the drop_jakarta_omit branch July 6, 2025 20:33
@onobc
Copy link
Contributor

onobc commented Jul 6, 2025

Probably this change can be made independently though?

Absolutely. Just noting the fact that it is also in start.spring.io. It might be safer to leave it as-is for a little bit to make sure this change does not cause issues. I remember it did initially cause a bit of grief (worked in Gradle but not Maven - or the other way around).

That being said, did we test this change in both Gradle and Maven?

@breun
Copy link
Contributor Author

breun commented Jul 6, 2025

I created a pull request for start.spring.io: spring-io/start.spring.io#1855

@onobc
Copy link
Contributor

onobc commented Jul 7, 2025

I created a pull request for start.spring.io: spring-io/start.spring.io#1855

Thanks @breun ! Do you mind verifying these changes w/ both Gradle and Maven if you did not already? As these options are consumed by the build plugins, I have previously seen inconsistent behavior between the two in this area.

Thanks

@breun
Copy link
Contributor Author

breun commented Jul 7, 2025

I have verified with Maven only, because that's what I use for my projects, but AFAIK these options just passed on to grpc-java, so it shouldn't matter whether you pass them via the Maven plugin or the Gradle plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants