Skip to content

Conversation

cppwfs
Copy link
Contributor

@cppwfs cppwfs commented Jul 9, 2025

Fixes: #10197

Update deprecated ctor to use an empty map for delegates instead of null.

Auto-cherry-pick to 6.4.x

Fixes: spring-projects#10197

Update deprecated ctor to use an empty map for delegates instead of null.

**Auto-cherry-pick to `6.4.x`**
@cppwfs cppwfs requested a review from artembilan July 9, 2025 14:46
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed **Auto-cherry-pick to 6.4.x** in the commit to let respective bots to do the work for us.
Thanks

@cppwfs
Copy link
Contributor Author

cppwfs commented Jul 9, 2025

I will update the PR comment with the cherrypick notation. But it is in the commit message.

@artembilan
Copy link
Member

cppwfs:SI-CODEC-CTOR-DEPRECATE

More convenient to use an issue number in the branch.
In this case that would be GH-10197.

No a problem at all: just sharing with you an experience how easier to manage issues and PRs.

@cppwfs
Copy link
Contributor Author

cppwfs commented Jul 9, 2025

My bad I thought we were to use the link itself instead of the GH number.
i.e. #10197

Should we use something like this:
A) fixes: GH-10197
Or
B) fixes: GH-10197

Will probably have to see the raw comment vs what it shows here, to see the differences 😄

@artembilan
Copy link
Member

No, I mean the local branch name:
image

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I added all the required changes into this PR.

Will be merged when build is green.

Thanks

@artembilan artembilan enabled auto-merge (squash) July 9, 2025 17:37
@artembilan artembilan merged commit 5450281 into spring-projects:6.5.x Jul 9, 2025
3 of 4 checks passed
@cppwfs cppwfs added this to the 7.0.0-M1 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants