GH-10083: Apply Nullability to test-support module #10211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: spring-projects#10083 * Add missed `package-info.java` to packages of the `test-support` module * Add `@NullMarked` and fix all the reported nullability failures * Move `hashCode()` and `equals()` in the `OnlyOnceTrigger` to the end of class for more logical class structure.
cppwfs
requested changes
Jul 22, 2025
...-test-support/src/main/java/org/springframework/integration/test/condition/package-info.java
Show resolved
Hide resolved
| @@ -1,4 +0,0 @@ | |||
| /** | |||
There was a problem hiding this comment.
Asking:
Why was this package-info removed?
There was a problem hiding this comment.
There is no content in this mail package at all.
So, no need in this directory and its dangling package-info.
Looks like I have missed to mention that in the commit message 😄
...on-test-support/src/main/java/org/springframework/integration/test/util/OnlyOnceTrigger.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Artem Bilan <[email protected]>
cppwfs
approved these changes
Jul 22, 2025
|
LGTM! |
|
Rebased, Squashed Merged Thanks for the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #10083
package-info.javato packages of thetest-supportmodule@NullMarkedand fix all the reported nullability failureshashCode()andequals()in theOnlyOnceTriggerto the end of class for more logical class structure.