GH-10083: Apply Nullability to some core support packages

spring-integration-core/src/main/java/org/springframework/integration/channel/DefaultHeaderChannelRegistry.java

@@ -259,6 +259,11 @@ public void run() {
 		}
 	}
 
+	@Override
+	public String getComponentType() {
+		return "channel";
+	}
+
 	protected record MessageChannelWrapper(MessageChannel channel, long expireAt) {
 
 	}

spring-integration-core/src/main/java/org/springframework/integration/codec/CodecMessageConverter.java

@@ -77,4 +77,9 @@ public Message<?> toMessage(Object payload, @Nullable MessageHeaders headers) {
 		}
 	}
 
+	@Override
+	public String getComponentType() {
+		return "converter";
+	}
+
 }

spring-integration-core/src/main/java/org/springframework/integration/context/IntegrationObjectSupport.java

@@ -138,15 +138,6 @@ public void setComponentName(String componentName) {
 		this.componentName = componentName;
 	}
 
-	/**
-	 * Subclasses may implement this method to provide component type information.
-	 */
-	@Override
-	@Nullable
-	public String getComponentType() {
-		return null;
-	}
-
 	@Override
 	public void setComponentSource(Object source) {
 		this.beanSource = source;

spring-integration-core/src/main/java/org/springframework/integration/dsl/RouterSpec.java

@@ -278,6 +278,11 @@ else if (conversionService.canConvert(key.getClass(), String.class)) {
 			}
 		}
 
+		@Override
+		public String getComponentType() {
+			return "router-mapping-provider";
+		}
+
 	}
 
 }

spring-integration-core/src/main/java/org/springframework/integration/endpoint/AbstractEndpoint.java

@@ -201,6 +201,11 @@ public final void stop(Runnable callback) {
 		}
 	}
 
+	@Override
+	public String getComponentType() {
+		return "endpoint";
+	}
+
 	/**
 	 * Stop the component and invoke callback.
 	 * @param callback the Runnable to invoke.

spring-integration-core/src/main/java/org/springframework/integration/handler/advice/AbstractRequestHandlerAdvice.java

@@ -73,6 +73,11 @@ public final Object invoke(final MethodInvocation invocation) throws Throwable {
 		}
 	}
 
+	@Override
+	public String getComponentType() {
+		return "advice";
+	}
+
 	/**
 	 * Subclasses implement this method to apply behavior to the {@link MessageHandler}.
 	 * <p>

spring-integration-core/src/main/java/org/springframework/integration/support/channel/BeanFactoryChannelResolver.java

@@ -21,6 +21,7 @@
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
+import org.jspecify.annotations.Nullable;
 
 import org.springframework.beans.BeansException;
 import org.springframework.beans.factory.BeanFactory;
@@ -52,9 +53,10 @@ public class BeanFactoryChannelResolver implements DestinationResolver<MessageCh
 
 	private final Lock lock = new ReentrantLock();
 
+	@SuppressWarnings("NullAway.Init")
 	private BeanFactory beanFactory;
 
-	private HeaderChannelRegistry replyChannelRegistry;
+	private @Nullable HeaderChannelRegistry replyChannelRegistry;
 
 	private volatile boolean initialized;
 
@@ -89,7 +91,6 @@ public void setBeanFactory(BeanFactory beanFactory) {
 
 	@Override
 	public MessageChannel resolveDestination(String name) {
-		Assert.state(this.beanFactory != null, "BeanFactory is required");
 		try {
 			return this.beanFactory.getBean(name, MessageChannel.class);
 		}

spring-integration-core/src/main/java/org/springframework/integration/support/channel/HeaderChannelRegistry.java

@@ -16,6 +16,8 @@
 
 package org.springframework.integration.support.channel;
 
+import org.jspecify.annotations.Nullable;
+
 import org.springframework.jmx.export.annotation.ManagedAttribute;
 import org.springframework.jmx.export.annotation.ManagedOperation;
 import org.springframework.messaging.MessageChannel;
@@ -37,7 +39,7 @@ public interface HeaderChannelRegistry {
 	 * @param channel The channel.
 	 * @return The channel name, or the channel if it is not a MessageChannel.
 	 */
-	Object channelToChannelName(Object channel);
+	@Nullable Object channelToChannelName(Object channel);
 
 	/**
 	 * Converts the channel to a name (String). If the channel is not a
@@ -48,15 +50,15 @@ public interface HeaderChannelRegistry {
 	 * @return The channel name, or the channel if it is not a MessageChannel.
 	 * @since 4.1
 	 */
-	Object channelToChannelName(Object channel, long timeToLive);
+	@Nullable Object channelToChannelName(Object channel, long timeToLive);
 
 	/**
 	 * Converts the channel name back to a {@link MessageChannel} (if it is
 	 * registered).
 	 * @param name The name of the channel.
 	 * @return The channel, or null if there is no channel registered with the name.
 	 */
-	MessageChannel channelNameToChannel(String name);
+	@Nullable MessageChannel channelNameToChannel(String name);
 
 	/**
 	 * @return the current size of the registry

spring-integration-core/src/main/java/org/springframework/integration/support/channel/package-info.java

@@ -0,0 +1,5 @@
+/**
+ * Provides classes supporting use of the channel.
+ */
+@org.jspecify.annotations.NullMarked
+package org.springframework.integration.support.channel;

spring-integration-core/src/main/java/org/springframework/integration/support/context/package-info.java

@@ -1,4 +1,5 @@
 /**
  * Provides classes supporting use of the application context.
  */
+@org.jspecify.annotations.NullMarked
 package org.springframework.integration.support.context;

spring-integration-core/src/main/java/org/springframework/integration/support/converter/AllowListDeserializingConverter.java

@@ -57,8 +57,7 @@ public class AllowListDeserializingConverter implements Converter<byte[], Object
 
 	private final Deserializer<Object> deserializer;
 
-	@Nullable
-	private final ClassLoader defaultDeserializerClassLoader;
+	private final @Nullable ClassLoader defaultDeserializerClassLoader;
 
 	private final boolean usingDefaultDeserializer;
 
@@ -136,15 +135,14 @@ public Object convert(byte[] source) {
 			if (this.usingDefaultDeserializer) {
 				return deserialize(byteStream);
 			}
-			else {
-				Object result = this.deserializer.deserialize(byteStream);
-				/* Even if there is no knowledge what is the target deserialization algorithm
-				 and malicious code may be executed already, it is still better to fail
-				 with untrusted data rather than just let it pass downstream.
-				 */
-				checkAllowList(result.getClass());
-				return result;
-			}
+
+			Object result = this.deserializer.deserialize(byteStream);
+			/* Even if there is no knowledge what is the target deserialization algorithm
+			 and malicious code may be executed already, it is still better to fail
+			 with untrusted data rather than just let it pass downstream.
+			 */
+			checkAllowList(result.getClass());
+			return result;
 		}
 		catch (Exception ex) {
 			throw new SerializationFailedException("Failed to deserialize payload. " +

spring-integration-core/src/main/java/org/springframework/integration/support/converter/DefaultDatatypeChannelMessageConverter.java

@@ -72,13 +72,11 @@ public void setBeanFactory(BeanFactory beanFactory) throws BeansException {
 	 * @return the converted payload or null if conversion is not possible.
 	 */
 	@Override
-	public Object fromMessage(Message<?> message, Class<?> targetClass) {
+	public @Nullable Object fromMessage(Message<?> message, Class<?> targetClass) {
 		if (this.conversionService.canConvert(message.getPayload().getClass(), targetClass)) {
 			return this.conversionService.convert(message.getPayload(), targetClass);
 		}
-		else {
-			return null;
-		}
+		return null;
 	}
 
 	@Override

spring-integration-core/src/main/java/org/springframework/integration/support/converter/MapMessageConverter.java

@@ -49,7 +49,7 @@ public class MapMessageConverter implements MessageConverter, BeanFactoryAware {
 
 	private boolean filterHeadersInToMessage;
 
-	private BeanFactory beanFactory;
+	private @Nullable BeanFactory beanFactory;
 
 	private MessageBuilderFactory messageBuilderFactory = new DefaultMessageBuilderFactory();
 
@@ -97,7 +97,6 @@ public void setFilterHeadersInToMessage(boolean filterHeadersInToMessage) {
 		this.filterHeadersInToMessage = filterHeadersInToMessage;
 	}
 
-	@Nullable
 	@Override
 	public Message<?> toMessage(Object object, @Nullable MessageHeaders messageHeaders) {
 		Assert.isInstanceOf(Map.class, object, "This converter expects a Map");
@@ -119,7 +118,6 @@ public Message<?> toMessage(Object object, @Nullable MessageHeaders messageHeade
 				.build();
 	}
 
-	@Nullable
 	@Override
 	public Object fromMessage(Message<?> message, Class<?> clazz) {
 		Map<String, Object> map = new HashMap<>();

spring-integration-core/src/main/java/org/springframework/integration/support/converter/ObjectStringMessageConverter.java

@@ -56,9 +56,7 @@ protected Object convertFromInternal(Message<?> message, Class<?> targetClass, @
 		if (payload instanceof String || payload instanceof byte[]) {
 			return super.convertFromInternal(message, targetClass, conversionHint);
 		}
-		else {
-			return payload.toString();
-		}
+		return payload.toString();
 	}
 
 }

spring-integration-core/src/main/java/org/springframework/integration/support/converter/PassThruMessageConverter.java

@@ -43,13 +43,12 @@ public Object fromMessage(Message<?> message, Class<?> targetClass) {
 	}
 
 	@Override
-	public Message<?> toMessage(Object payload, @Nullable MessageHeaders headers) {
+	public @Nullable Message<?> toMessage(Object payload, @Nullable MessageHeaders headers) {
 		if (payload instanceof byte[]) {
 			return MessageBuilder.withPayload(payload).copyHeaders(headers).build();
 		}
-		else {
-			return null;
-		}
+
+		return null;
 	}
 
 }

spring-integration-core/src/main/java/org/springframework/integration/support/converter/SimpleMessageConverter.java

@@ -51,7 +51,7 @@ public class SimpleMessageConverter implements MessageConverter, BeanFactoryAwar
 
 	private boolean messageBuilderFactorySet;
 
-	private BeanFactory beanFactory;
+	private @Nullable BeanFactory beanFactory;
 
 	public SimpleMessageConverter() {
 	}
@@ -104,9 +104,8 @@ protected MessageBuilderFactory getMessageBuilderFactory() {
 		return this.messageBuilderFactory;
 	}
 
-	@Nullable
 	@Override
-	public Message<?> toMessage(Object object, @Nullable MessageHeaders headers) {
+	public @Nullable Message<?> toMessage(Object object, @Nullable MessageHeaders headers) {
 		try {
 			return this.inboundMessageMapper.toMessage(object, headers);
 		}
@@ -115,9 +114,8 @@ public Message<?> toMessage(Object object, @Nullable MessageHeaders headers) {
 		}
 	}
 
-	@Nullable
 	@Override
-	public Object fromMessage(Message<?> message, Class<?> targetClass) {
+	public @Nullable Object fromMessage(Message<?> message, Class<?> targetClass) {
 		try {
 			return this.outboundMessageMapper.fromMessage(message);
 		}
@@ -132,7 +130,7 @@ private class DefaultInboundMessageMapper implements InboundMessageMapper<Object
 		}
 
 		@Override
-		public Message<?> toMessage(@Nullable Object object, @Nullable Map<String, Object> headers) {
+		public @Nullable Message<?> toMessage(@Nullable Object object, @Nullable Map<String, Object> headers) {
 			if (object == null) {
 				return null;
 			}
@@ -153,8 +151,8 @@ private static class DefaultOutboundMessageMapper implements OutboundMessageMapp
 		}
 
 		@Override
-		public Object fromMessage(@Nullable Message<?> message) {
-			return (message != null) ? message.getPayload() : null;
+		public Object fromMessage(Message<?> message) {
+			return message.getPayload();
 		}
 
 	}

spring-integration-core/src/main/java/org/springframework/integration/support/converter/package-info.java

@@ -1,6 +1,5 @@
 /**
  * Provides classes supporting message conversion.
  */
-@org.springframework.lang.NonNullApi
-@org.springframework.lang.NonNullFields
+@org.jspecify.annotations.NullMarked
 package org.springframework.integration.support.converter;

spring-integration-core/src/main/java/org/springframework/integration/transaction/ExpressionEvaluatingTransactionSynchronizationProcessor.java

@@ -131,6 +131,11 @@ public void processAfterRollback(IntegrationResourceHolder holder) {
 		doProcess(holder, this.afterRollbackExpression, this.afterRollbackChannel, "afterRollback");
 	}
 
+	@Override
+	public String getComponentType() {
+		return "processor";
+	}
+
 	private void doProcess(IntegrationResourceHolder holder, Expression expression,
 			@Nullable MessageChannel messageChannel, String expressionType) {
 

spring-integration-core/src/main/java/org/springframework/integration/transformer/AbstractTransformer.java

@@ -45,6 +45,11 @@ public final Message<?> transform(Message<?> message) {
 		}
 	}
 
+	@Override
+	public String getComponentType() {
+		return "transformer";
+	}
+
 	/**
 	 * Subclasses must implement this method to provide the transformation
 	 * logic. If the return value is itself a Message, it will be used as the

spring-integration-core/src/test/java/org/springframework/integration/handler/MessageHandlerChainTests.java

@@ -185,6 +185,11 @@ public void handleMessage(Message<?> message) {
 			output.send(message);
 		}
 
+		@Override
+		public String getComponentType() {
+			return "producer";
+		}
+
 	}
 
 }

spring-integration-ip/src/main/java/org/springframework/integration/ip/tcp/connection/AbstractConnectionFactory.java

@@ -165,6 +165,11 @@ public ApplicationEventPublisher getApplicationEventPublisher() {
 		return this.applicationEventPublisher;
 	}
 
+	@Override
+	public String getComponentType() {
+		return "connection";
+	}
+
 	/**
 	 * Sets socket attributes on the socket.
 	 * @param socket The socket.

spring-integration-ip/src/main/java/org/springframework/integration/ip/tcp/connection/CachingClientConnectionFactory.java

@@ -140,7 +140,7 @@ public void setComponentName(String componentName) {
 	}
 
 	@Override
-	public @Nullable String getComponentType() {
+	public String getComponentType() {
 		return this.targetConnectionFactory.getComponentType();
 	}
 

spring-integration-ip/src/main/java/org/springframework/integration/ip/tcp/connection/ThreadAffinityClientConnectionFactory.java

@@ -106,7 +106,7 @@ public void setApplicationEventPublisher(ApplicationEventPublisher applicationEv
 	}
 
 	@Override
-	public @Nullable String getComponentType() {
+	public String getComponentType() {
 		return this.connectionFactory.getComponentType();
 	}