GH-10083: Add nullability to core metadata #10384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ConcurrentMetadataStore.java: Added @nullable annotation to putIfAbsent method return type for better null safety. * MetadataStore.java: Added @nullable annotations to get and remove method return types to indicate they can return null. * PropertiesPersistingMetadataStore.java: Removed explicit null checks with Assert.notNull calls and added @nullable annotations to method signatures while simplifying saveMetadata logic. * SimpleMetadataStore.java: Added @nullable annotations to get, remove, and putIfAbsent method return types for consistency with interface. * MetadataStoreSelector.java: Added Assert.state calls to validate that keyStrategy and valueStrategy do not return null values.
cppwfs
requested review from
tzolov and
artembilan
and removed request for
tzolov
artembilan
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Nullableannotation to putIfAbsent method return type for better null safety.@Nullableannotations to method signatures while simplifying saveMetadata logic.@Nullableannotations to get, remove, and putIfAbsent method return types for consistency with interface.