GH-3954: Add warning about @PostConstruct timing with NewTopic beans #4069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NewTopic beans Signed-off-by: Chaedie <[email protected]>
artembilan
requested changes
Sep 2, 2025
| When sending messages from Spring components, avoid using `@PostConstruct` methods | ||
| if you rely on automatic topic creation via `NewTopic` beans. `@PostConstruct` runs | ||
| before the application context is fully ready, which may cause | ||
| `UnknownTopicOrPartitionException` on clean brokers. |
There was a problem hiding this comment.
All good, but, please, consider to fix your change according to best practice rules we try to follow: https://asciidoctor.org/docs/asciidoc-recommended-practices/#one-sentence-per-line.
It also would be great to make the text as "personless".
Use the language which would not be like pointing to someone.
In other words try to avoid "you", "we", "they" etc.
There was a problem hiding this comment.
Thanks for advice.
I revised documentation.
Signed-off-by: Chaedie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #3954
Added a warning note to the topic configuration docs about
@PostConstructtiming issues.