Skip to content

Conversation

snprajwal
Copy link

@snprajwal snprajwal commented May 13, 2025

This addresses the lint raised by gopls on sqlc's generated Go files for modernizing the usage of an empty interface for the any type.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🔧 golang labels May 13, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 13, 2025
@snprajwal
Copy link
Author

Interesting, it looks like the generated names for constants are not escaped

snprajwal added 2 commits May 13, 2025 21:52
Also adds `any` as a reserved keyword, as it was introduced in Go 1.18.

Signed-off-by: Prajwal S N <[email protected]>
@snprajwal
Copy link
Author

@kyleconroy I just realised this might be noisier than needed, since the linter ignores generated files. Would you want me to split the bug fix out into a separate PR and close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files. 🔧 golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant