Skip to content

Conversation

kaelemc
Copy link
Member

@kaelemc kaelemc commented Aug 24, 2025

Tools command to expose a custom code-server image with the clab vsc ext preinstalled.

cc @FloSch62

@kaelemc kaelemc force-pushed the tools-code-server branch from 77e1436 to a88d923 Compare August 24, 2025 03:23
ToolsSSHX *ToolsSSHXOptions
ToolsVeth *ToolsVethOptions
ToolsVxlan *ToolsVxlanOptions
ToolsCodeServer *ToolsCodeServerOptions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welcome to the cmd package shenanigans @kaelemc <3 :D

@kaelemc
Copy link
Member Author

kaelemc commented Sep 3, 2025

I will have to park this one for now.

There is an issue where the webviews cannot work unless a trusted HTTPS cert is provided. (coder/code-server#6656).. This kind of renders a lot of the extension functionality useless.

@kaelemc kaelemc closed this Sep 3, 2025
@kaelemc
Copy link
Member Author

kaelemc commented Sep 3, 2025

Seems we can do with raw HTTP.. just some changes required to make topoviewer work

@kaelemc kaelemc reopened this Sep 3, 2025
@FloSch62 FloSch62 marked this pull request as ready for review September 18, 2025 16:38
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 11.59420% with 427 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.50%. Comparing base (b7f9f0c) to head (6e04433).

Files with missing lines Patch % Lines
cmd/tools_code_server.go 9.75% 395 Missing and 3 partials ⚠️
mocks/mockruntime/runtime.go 0.00% 9 Missing ⚠️
cmd/tools.go 45.45% 4 Missing and 2 partials ⚠️
runtime/docker/docker.go 0.00% 6 Missing ⚠️
runtime/ignite/ignite.go 0.00% 6 Missing ⚠️
runtime/podman/podman.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2777      +/-   ##
==========================================
- Coverage   55.89%   55.50%   -0.39%     
==========================================
  Files         207      208       +1     
  Lines       24362    24837     +475     
==========================================
+ Hits        13617    13787     +170     
- Misses       9524     9803     +279     
- Partials     1221     1247      +26     
Files with missing lines Coverage Δ
cmd/options.go 89.65% <100.00%> (+0.31%) ⬆️
cmd/tools_api_start.go 69.75% <100.00%> (+0.56%) ⬆️
cmd/tools_api_status.go 86.51% <100.00%> (ø)
runtime/runtime.go 90.90% <ø> (ø)
runtime/podman/podman.go 0.30% <0.00%> (-0.01%) ⬇️
cmd/tools.go 81.25% <45.45%> (-7.43%) ⬇️
runtime/docker/docker.go 68.15% <0.00%> (-0.48%) ⬇️
runtime/ignite/ignite.go 0.29% <0.00%> (-0.01%) ⬇️
mocks/mockruntime/runtime.go 8.88% <0.00%> (-0.32%) ⬇️
cmd/tools_code_server.go 9.75% <9.75%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants