Use BCL Curve25519 for Windows 10+ #1702
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-xu
changed the title
scott-xu
changed the title
scott-xu
requested review from
drieseng,
WojciechNagorski and
Rob-Hague
as code owners
scott-xu
force-pushed
the
bcl-curve25519
branch
from
f5486b5 to
9d15116
Compare
Rob-Hague
reviewed
Sep 26, 2025
| internal abstract partial class KeyExchangeEC | ||
| { | ||
| private sealed class BclImpl : Impl | ||
| protected internal sealed class BclImpl : Impl |
There was a problem hiding this comment.
nit, here and elsewhere
Suggested change
| protected internal sealed class BclImpl : Impl | |
| protected sealed class BclImpl : Impl |
| { | ||
| base.Start(session, message, sendClientInitMessage); | ||
| #if NET | ||
| if (System.OperatingSystem.IsWindowsVersionAtLeast(10)) |
There was a problem hiding this comment.
is it all versions of windows 10?
| { | ||
| private readonly ECDomainParameters _domainParameters; | ||
| private readonly ECDHCBasicAgreement _keyAgreement; | ||
| private readonly ECDHBasicAgreement _keyAgreement; |
There was a problem hiding this comment.
what does this change do?
|
actually, it is not working on my win10 22H2 machine (connected aborted). develop branch works fine, using curve25519-sha256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning in Windows 10, CNG provides support for Curve25519.
See https://learn.microsoft.com/en-us/windows/win32/seccng/cng-named-elliptic-curves