better queryables and illegal_argument_exception fix for OS items load #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generic attributes
"$schema" to the one from pgstac (seems newer and more advanced) "$id" made it dynamic
Zaczero
reviewed
Sep 5, 2025
| async def get_queryables( | ||
| self, collection_id: Optional[str] = None, **kwargs | ||
| ) -> Dict[str, Any]: | ||
| request: Optional[Request] = kwargs.get("request").url |
There was a problem hiding this comment.
Here, you put code before a docstring, which I believe removes the docstring from the method. This typing : Optional[Request] also seems incorrect. url with either be of Url or str type.
Zaczero
reviewed
Sep 5, 2025
| queryables: Dict[str, Any] = { | ||
| "$schema": "https://json-schema.org/draft/2019-09/schema", | ||
| "$id": "https://stac-api.example.com/queryables", | ||
| "$schema": "https://json-schema.org/draft-07/schema#", |
There was a problem hiding this comment.
An empty fragment # in links does nothing. May as well remove the extra character to keep the link clean.
MathewNWSH
changed the title
jonhealy1
requested changes
Sep 22, 2025
There was a problem hiding this comment.
@MathewNWSH This looks really good. Can you add an entry in the changelog, in the Unreleased section. It looks like linting is failing too. Thanks!
|
hey @jonhealy1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added missing copy(), updated DEFAULT_QUERYABLES so it contains only generic attributes
Description:
PR Checklist:
pre-commit run --all-files)make test)