fix: Add startupProbe to prevent Superset startup problems #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
NickLarsenNZ
requested changes
Aug 4, 2025
CHANGELOG.md
Outdated
Comment on lines
7
to
8
| - Fix container not starting because Superset was starting too slow and was killed because a failing liveness probe. | ||
| We now add a proper startup probe, which allows Superset to take longer to start up ([#654]). |
There was a problem hiding this comment.
Indenation
Suggested change
| - Fix container not starting because Superset was starting too slow and was killed because a failing liveness probe. | |
| We now add a proper startup probe, which allows Superset to take longer to start up ([#654]). | |
| - Fix container not starting because Superset was starting too slow and was killed because a failing liveness probe. | |
| We now add a proper startup probe, which allows Superset to take longer to start up ([#654]). |
But I think it could be briefer:
Suggested change
| - Fix container not starting because Superset was starting too slow and was killed because a failing liveness probe. | |
| We now add a proper startup probe, which allows Superset to take longer to start up ([#654]). | |
| - Add startup probe to give Superset longer to start up than the default ([#654]). |
There was a problem hiding this comment.
I prefer the current two sentences as they make a bit clearer what the problem was exactly and what the impact was.
than the default
There is no default, only before (like 60s) and after (~10 minutes) ^^
There was a problem hiding this comment.
There is no default, only before (like 60s) and after (~10 minutes) ^^
Where was the 60 defined?
There was a problem hiding this comment.
15s initial_delay_seconds + failure_threshold (3) * period_seconds (15s)
Co-authored-by: Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Superset 4.0 and 4.1 both failed to start quick enough on a customer setup on Rhoencloud and crashlooped.
Fixed it via podOverrides, adding the probe to the operator here
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker