Skip to content

Conversation

brymut
Copy link
Contributor

@brymut brymut commented Aug 25, 2025

Description

closes #2042

Add visual enhancement to search results to improve readability w. Using existing brand colours with appropriate contrast:

  • Grey background for each item with margin
  • Left border line, colour coded to differentiate between posts and comments.
  • Legend guide for colours to guide users on the difference between the results.

Screenshots

Desktop (light mode)
Screenshot 2025-09-01 at 21 49 17

Desktop (dark mode)
Screenshot 2025-09-01 at 21 48 14

Mobile (light mode)
Screenshot 2025-09-01 at 21 49 10

Mobile (dark mode)
Screenshot 2025-09-01 at 21 48 29

Additional Context

Was anything unclear during your work on this PR? Anything we should definitely take a closer look at?

Checklist

Are your changes backward compatible? Please answer below:
Y
For example, a change is not backward compatible if you removed a GraphQL field or dropped a database column.

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
10

For frontend changes: Tested on mobile, light and dark mode? Please answer below:
Y

Did you introduce any new environment variables? If so, call them out explicitly here:
N

@brymut brymut force-pushed the enhance/search-results-ui branch from 0a76f8d to e3eaa1b Compare August 25, 2025 12:01
@brymut
Copy link
Contributor Author

brymut commented Aug 25, 2025

Also just noticed an interesting rounding error for the sats balance.

@brymut brymut marked this pull request as ready for review August 25, 2025 12:05
@huumn
Copy link
Member

huumn commented Aug 29, 2025

tbh I was expecting something more subtle and/or familiar. but tbf I don't know what that looks like.

this gets the job done though. I just need more time to think about this before deciding to merge it

@brymut
Copy link
Contributor Author

brymut commented Aug 30, 2025

ok, was just following the spec. My rationale was just grabbing the background grey from how its handled in comments to separate the results. And to differentiate between comments & posts I grabbed colors used elsewhere in the UI so as to not veer off from existing brand identity, otherwise was just following spec.

Screenshot 2025-08-30 at 06 49 48

@brymut brymut force-pushed the enhance/search-results-ui branch from e3eaa1b to ba42078 Compare September 1, 2025 14:49
@brymut
Copy link
Contributor Author

brymut commented Sep 1, 2025

tbh I was expecting something more subtle and/or familiar. but tbf I don't know what that looks like.

Reduced the thickness of the border line to help with subtlety, otherwise my rationale is on the comment above. Updated screenshots in the PR desc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance search UI to distinguish results better
2 participants