Skip to content

feat(observability): add send_resolved field #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rubenhoenle
Copy link
Member

@rubenhoenle rubenhoenle commented Jul 31, 2025

Description

relates to STACKITTPR-283

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@rubenhoenle rubenhoenle self-assigned this Jul 31, 2025
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance 39.26% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/datasource.go 0.00% (ø) 72 0 72
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/resource.go 42.82% (ø) 794 340 454

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/observability_acc_test.go

Copy link

github-actions bot commented Aug 8, 2025

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold Stale PR is marked as stale due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant