Prevent deleting proxy containers on restart #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1080
When ToolHive restarts a workload it checks if the container already exists and can be reused. If it cannot be reused, it deletes it and creates a new container.
This happens for every container in the workload, including egress and dns containers that are created when network isolation is enabled.
The code previously recreated the egress and dns containers, and then proceeded to remove them when recreating the core MCP server container, because it was removing all associated workloads.
With this update, it only deletes the container that it's about to recreate and leaves the associated containers, assuming they've already updated themselves.
This is a similar issue to what we saw earlier with the network being deleted.