-
Notifications
You must be signed in to change notification settings - Fork 110
Support Google introspection endpoint #1590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd like to decouple the google logic a bit more
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1590 +/- ##
==========================================
+ Coverage 33.42% 33.90% +0.48%
==========================================
Files 216 217 +1
Lines 26716 27071 +355
==========================================
+ Hits 8929 9178 +249
- Misses 17138 17212 +74
- Partials 649 681 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Google doesn't follow the usual RFC 7662 format but instead uses their own. This PR adds support for parsgin their format if using a well-known Google endpoint. To test: - Go to Google OAuth 2.0 Playground - Select the scopes you want (e.g. `https://www.googleapis.com/auth/userinfo.email`) - Click "Authorize APIs" and complete the OAuth flow You'll get an access token that you can copy and use in the inspector. Fixes: #1411
ca048f6
to
bfa5b20
Compare
bfa5b20
to
742de23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i could not test with tailscale, their server is broken. But code looks good to me
Google doesn't follow the usual RFC 7662 format but instead uses their
own. This PR adds support for parsgin their format if using a well-known
Google endpoint.
To test:
https://www.googleapis.com/auth/userinfo.email
)You'll get an access token that you can copy and use in the inspector.
Fixes: #1411