Fix flacky tests #2178
Open
Fix flacky tests #2178
+40
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new function for initialize test logger Signed-off-by: NastyaAR <[email protected]>
eleftherias
reviewed
Oct 16, 2025
There was a problem hiding this comment.
Thanks for the PR @NastyaAR!
The overall approach looks good, I've left a few comments inline.
pkg/logger/logger.go
Outdated
| return unstructuredLogs | ||
| } | ||
|
|
||
| func InitializeTest() *observer.ObservedLogs { |
There was a problem hiding this comment.
Since this is only used in config_test.go let's make it a test helper in that file.
pkg/logger/logger.go
Outdated
|
|
||
| logger := zap.New(core) | ||
| zap.ReplaceGlobals(logger) | ||
|
|
There was a problem hiding this comment.
Let's add a cleanup step here that restores the global logger
originalLogger := zap.L()
zap.ReplaceGlobals(testLogger)
t.Cleanup(func() {
zap.ReplaceGlobals(originalLogger)
})
pkg/client/config_test.go
Outdated
| } | ||
|
|
||
| func TestFindClientConfigs(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
We cannot run this test in parallel with others because it replaces the global logger. If multiple tests do this, it's not clear which logger will be used.
* transfer init test logger function from logger to config_test, make it helper * add cleanup with restoring original logger * make test sequential Signed-off-by: NastyaAR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem occured due to parallel reading of os.Stderr (logger.Initialize ->logger.InitializeWithEnv -> zap.Config.Build) and writing to it when intercepting stderr in TestFindClientConfigs.
Changes