DRAFT: adds missing tests for pkg/labels and pkg/networking/port
#2181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is using assert.Equal() to directly compare tool slices, which requires exact order matching. However, the tools in the response can come in any order (likely from map iteration), causing intermittent failures. Using an assert.ElementsMatch should allow us to match regardless of order Signed-off-by: ChrisJBurns <[email protected]>
Signed-off-by: ChrisJBurns <[email protected]>
ChrisJBurns
changed the title
pkg/labels and pkg/networking/portpkg/labels and pkg/networking/port
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2181 +/- ##
==========================================
+ Coverage 52.67% 52.91% +0.23%
==========================================
Files 223 223
Lines 29037 29037
==========================================
+ Hits 15296 15364 +68
+ Misses 12605 12521 -84
- Partials 1136 1152 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were simple enough to add, may as well add them for extra assurances