Skip to content

Conversation

@VisruthSK
Copy link
Member

Fixes #380. Opted to change to [0,1] since that appeared elsewhere in the documentation. Bumped roxygen to latest version

@VisruthSK VisruthSK requested a review from jgabry October 23, 2025 19:52
@jgabry
Copy link
Member

jgabry commented Oct 23, 2025

Thanks! Can you regenerate the .Rd file? Otherwise this seems ready to go.

@jgabry
Copy link
Member

jgabry commented Oct 23, 2025

Oh these are internal functions, never mind!

@VisruthSK
Copy link
Member Author

I did redocument and some other links were updated--seem to be ggplot2 related.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (fcb73c9) to head (f68f169).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          35       35           
  Lines        5749     5749           
=======================================
  Hits         5670     5670           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge once the checks pass. Thanks @VisruthSK.

@VisruthSK
Copy link
Member Author

Is it ok that the ubuntu devel is taking forever to run the tests?

@VisruthSK VisruthSK merged commit 633addd into master Oct 23, 2025
6 checks passed
@VisruthSK VisruthSK deleted the fix-documentation-note branch October 23, 2025 20:48
@jgabry
Copy link
Member

jgabry commented Oct 23, 2025

Is it ok that the ubuntu devel is taking forever to run the tests?

I think this is because r-devel itself changes frequently and therefore dependencies (including ones that take a while to compile) are reinstalled frequently instead of using cached versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Escape brackets in documentation

4 participants