Skip to content

STAN_OPENCL implies STANCFLAGS=--use-opencl, avoid duplicates #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

STAN_OPENCL implies STANCFLAGS=--use-opencl, avoid duplicates #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7456830
STAN_OPENCL implies STANCFLAGS=--use-opencl, avoid duplicates
WardBrian Sep 9, 2025
bd4ba50
Update other test
WardBrian Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmdstanpy/compilation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ def validate_stanc_opts(self) -> None:
self._cpp_options = {'STAN_OPENCL': 'TRUE'}
else:
self._cpp_options['STAN_OPENCL'] = 'TRUE'
ignore.append(key)
elif key.startswith('O'):
if has_o_flag:
get_logger().warning(
Expand Down
3 changes: 2 additions & 1 deletion test/test_compiler_opts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ def test_opts_stanc_opencl() -> None:
stanc_opts['use-opencl'] = 'foo'
opts = CompilerOptions(stanc_options=stanc_opts)
opts.validate()
assert opts.compose() == ['STANCFLAGS+=--use-opencl', 'STAN_OPENCL=TRUE']
# cmdstan STAN_OPENCL implies STANCFLAGS+=--use-opencl
assert opts.compose() == ['STAN_OPENCL=TRUE']


def test_opts_stanc_ignore() -> None:
Expand Down
2 changes: 1 addition & 1 deletion test/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,11 +155,11 @@ def test_stanc_options() -> None:
stanc_opts = model.stanc_options
assert stanc_opts[f'O{optim}']
assert stanc_opts['allow-undefined']
assert stanc_opts['use-opencl']
assert stanc_opts['name'] == 'foo'

cpp_opts = model.cpp_options
assert cpp_opts['STAN_OPENCL'] == 'TRUE'
assert not stanc_opts.get('use-opencl')

with pytest.raises(ValueError):
bad_opts = {'X': True}
Expand Down
Loading