-
Notifications
You must be signed in to change notification settings - Fork 804
feat(provider): Add Brother ID domain resolution support #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right stuff in the right place, without a deep dive into implementation.
LGTM
…net.js into starnet_brother
gm @tabaktoni, have made some changes, looks correct to me. |
hi team, bumping this up! |
@tabaktoni should have a look soon. |
gmgm @tabaktoni |
gm @PhilippeR26 @tabaktoni |
Motivation and Resolution
This PR introduces Brother ID integration into Starknet.js, providing methods to interact with .brother domain names. This addition allows developers to easily resolve .brother domains to addresses and vice versa, similar to existing StarknetId functionality.
RPC version
N/A - This feature works with existing RPC implementations.
Usage related changes
BrotherId
class with methods to interact with Brother Identity contractsgetBrotherName
: Get the primary Brother domain for an addressgetAddressFromBrotherName
: Resolve a Brother domain to its addressgetBrotherProfile
: Get complete profile information for a Brother domainisBrotherDomain
to validate .brother domainsDevelopment related changes
src/provider/extensions/brotherId.ts
with Brother ID implementationsrc/provider/extensions/default.ts
to include BrotherId in the RPC Provider mixinBrotherProfile
for structured domain informationChecklist: