feat: ressourceBounds are taking into account L2_MIN_PRICE #1520
+66
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
estimateFeeis providing aresourceBoundobject that is not taking into account L2 MIN PRICE.This value is 3 Gfri, and is defined in https://governance.starknet.io/voting-proposals/9
Usage related changes
Today, if
l2.max_price_per_unitis lower than L2_MIN_PRICE, the node will answer with an error 53.Now, automatic definition of resourceBounds is taking care of L2_MIN_PRICE and is not generating errors.
User can anyway defines manually resourceBounds with any (possibly invalid) value.
Development related changes
Just added 2 functions to get min and max of a collection of bigints.
Checklist: