Skip to content

Conversation

@PhilippeR26
Copy link
Collaborator

Motivation and Resolution

estimateFee is providing a resourceBound object that is not taking into account L2 MIN PRICE.
This value is 3 Gfri, and is defined in https://governance.starknet.io/voting-proposals/9

Usage related changes

Today, if l2.max_price_per_unit is lower than L2_MIN_PRICE, the node will answer with an error 53.
Now, automatic definition of resourceBounds is taking care of L2_MIN_PRICE and is not generating errors.
User can anyway defines manually resourceBounds with any (possibly invalid) value.

Development related changes

Just added 2 functions to get min and max of a collection of bigints.

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant