Bump 1.0.0 #177
Open
Bump 1.0.0 #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdelabro
requested review from
dan-starkware,
gabrielbosio and
pefontana
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Bump the
corecrate to version1.0.0.Bump cargo
editionto 2024.Fix the feature required for benches (they have been broken for some time)
Format with the new edition
Why?
The crate is now 2.5 years old. It is widely used in Starknet Rust ecosystem for a diversity of projects.
It has been well tested and proved reliable.
During the last 4 months, we have emptied the backlog of bugs for this repo.
We also did some refactoring to clean it up and help with maintenance, and added some quality-of-life improvements.
The next phase will be about bettering documentation and adding even more types (see #159 and #171), but we believe that, in its current state, the lib can be considered mature and not subject to many future breaking changes.
We also receive some complaints from downstream users about having to deal with mandatory updates every time we push a breaking change (due to only using the minor version). They requested that we release a v1 of the lib, so that they can use it for a longer period of time, and only update to a newer release on their own agenda, rather than every time we create a new one.
So, if you agree to merge this one, the next release will be tagged as v1.0.0, and we will start embracing normal semantic versioning.