flow_control: Integrate the new code for simple boolean ifs.

[liorgold2]

Stack:

• Remove unnecessary mut. #8095
• flow_control: Refactor FlowControlGraphBuilder. #8094
• flow_control: Support match expressions. #8093
• flow_control: Support inner enums. #8092
• flow_control: Integrate the new code for simple boolean ifs. #8086 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[orizi]

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-lowering/src/borrow_check/test_data/borrow_check line 853 at r1 (raw file):

  (v12: test::A) <- struct_construct(v9{`a`})
End:
  Return(v12, v11)

are there cases where this would cause a regression?

or would following optimizations remove the issue?
(or sierra-gen end of function "push" would make this irrelevant?)

Code quote:

  Goto(blk3, {v6 -> v9})

blk2:
Statements:
  (v10: core::integer::u32) <- struct_destructure(v0{`if true { bar(@a.x); }`})
End:
  Goto(blk3, {v10 -> v9})

blk3:
Statements:
  (v11: ()) <- struct_construct()
  (v12: test::A) <- struct_construct(v9{`a`})
End:
  Return(v12, v11)

[liorgold2]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-lowering/src/borrow_check/test_data/borrow_check line 853 at r1 (raw file):

Previously, orizi wrote…

are there cases where this would cause a regression?

or would following optimizations remove the issue?
(or sierra-gen end of function "push" would make this irrelevant?)

I think @ilyalesokhin-starkware said this is the preferred way. It's hard for me to say if it'll cause regression in some cases. I think the new way decreases the size of the remapping (better to remap the necessary members of a struct than the entire struct)

[orizi]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

[ilyalesokhin-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)