refactor(test): remove compare_spans util
#8342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2025
|
This change is |
Contributor
Author
orizi
approved these changes
Sep 4, 2025
Collaborator
orizi
left a comment
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
giladchase
force-pushed
the
gilad/09-03-refactor_test_remove_compare_byte_array_util_and_rework_tests
branch
from
c8e567b to
f5e8ce6
Compare
giladchase
force-pushed
the
gilad/09-04-refactor_test_remove_compare_spans_util
branch
from
6e650cf to
2f2ffe3
Compare
orizi
approved these changes
Sep 4, 2025
Collaborator
orizi
left a comment
orizi
left a comment
There was a problem hiding this comment.
@orizi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
TomerStarkware
approved these changes
Sep 4, 2025
Collaborator
TomerStarkware
left a comment
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed all commit messages.
Reviewable status:
dean-starkware
changed the base branch from
gilad/09-03-refactor_test_remove_compare_byte_array_util_and_rework_tests
to
main
It was pre-PartialEq legacy code
giladchase
force-pushed
the
gilad/09-04-refactor_test_remove_compare_spans_util
branch
from
2f2ffe3 to
0ecba37
Compare
Merge activity
|
This was referenced Sep 14, 2025
orizi
deleted the
gilad/09-04-refactor_test_remove_compare_spans_util
branch
This was referenced Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was pre-PartialEq legacy code