Skip to content

Conversation

@orizi
Copy link
Collaborator

@orizi orizi commented Sep 28, 2025

SIERRA_UPDATE_PATCH_CHANGE_TAG=Just performance gain - no interface effect.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi marked this pull request as ready for review September 28, 2025 14:24
@orizi orizi force-pushed the gt/orizi/09-28-performance_sierra-calcs_made_topological_order_not_require_vec_alloc branch from 9e583b7 to 4076e3f Compare September 29, 2025 04:54
@orizi orizi force-pushed the gt/orizi/09-28-performance_sierra-gas_gas_computation_performance_improvements branch from c6074dd to 4612af1 Compare September 29, 2025 04:54
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@TomerStarkware reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi changed the base branch from gt/orizi/09-28-performance_sierra-gas_gas_computation_performance_improvements to graphite-base/8477 September 29, 2025 09:59
@orizi orizi force-pushed the gt/orizi/09-28-performance_sierra-calcs_made_topological_order_not_require_vec_alloc branch from 4076e3f to dfc6e2b Compare September 29, 2025 10:00
@orizi orizi force-pushed the graphite-base/8477 branch from 4612af1 to 07d0f2a Compare September 29, 2025 10:00
@orizi orizi changed the base branch from graphite-base/8477 to main September 29, 2025 10:00
@orizi orizi force-pushed the gt/orizi/09-28-performance_sierra-calcs_made_topological_order_not_require_vec_alloc branch 2 times, most recently from f3f6eb1 to 979a421 Compare October 8, 2025 09:07
SIERRA_UPDATE_PATCH_CHANGE_TAG=Just performance gain - no interface effect.
@orizi orizi force-pushed the gt/orizi/09-28-performance_sierra-calcs_made_topological_order_not_require_vec_alloc branch from 979a421 to 6d5583a Compare October 13, 2025 12:06
@orizi orizi added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit de30479 Oct 15, 2025
54 checks passed
@orizi orizi deleted the gt/orizi/09-28-performance_sierra-calcs_made_topological_order_not_require_vec_alloc branch October 16, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants