Skip to content

improve SignatureError handling #8985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FroyaTheHen merged 1 commit into from
Dec 12, 2025
Merged

improve SignatureError handling #8985

FroyaTheHen merged 1 commit into from
Dec 12, 2025
+110 −264

Conversation

@FroyaTheHen
Copy link
Collaborator

@FroyaTheHen FroyaTheHen commented Dec 9, 2025

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@FroyaTheHen FroyaTheHen mentioned this pull request Dec 9, 2025
Merged
@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Dec 9, 2025

This change is Reviewable

@FroyaTheHen FroyaTheHen self-assigned this Dec 9, 2025
@FroyaTheHen FroyaTheHen requested review from Draggu and orizi December 9, 2025 04:25
@FroyaTheHen FroyaTheHen marked this pull request as ready for review December 9, 2025 04:25
orizi
orizi approved these changes Dec 9, 2025
View reviewed changes
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Draggu)

orizi
orizi approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Draggu)

@FroyaTheHen FroyaTheHen changed the base branch from spr/main/947b6186 to main December 12, 2025 00:46
@FroyaTheHen FroyaTheHen added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit 0fbbea2 Dec 12, 2025
105 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orizi orizi orizi approved these changes

@Draggu Draggu Awaiting requested review from Draggu

Assignees

@FroyaTheHen FroyaTheHen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FroyaTheHen @reviewable-StarkWare @orizi