Skip to content

Conversation

@Galoretka
Copy link
Contributor

@Galoretka Galoretka commented Dec 9, 2025

This function didn’t use the name parameter and it was explicitly prefixed with _, indicating it was dead weight. The function is private and only used in this module, so changing the signature is safe. Updated the two call sites to pass just generics

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Galoretka)


crates/cairo-lang-proc-macros/src/debug.rs line 46 at r1 (raw file):

    // a) impl-side generics  = original + 'a + T
    let impl_generics = create_impl_generics(name, generics);

rather keep it consistent with the rest of the items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants