Skip to content

Conversation

@TomerStarkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@TomerStarkware TomerStarkware requested a review from orizi December 10, 2025 14:28
@TomerStarkware TomerStarkware marked this pull request as ready for review December 10, 2025 14:29
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)


crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 60 at r1 (raw file):

        ConstValue::Struct(members, ty) => {
            // Only convert to SpecializationArg::Struct if the type is actually a concrete struct,
            // not a closure or fixed size array.

why not fixed-sized arrays and tuples as well?

Copy link
Collaborator Author

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-lowering/src/optimizations/const_folding.rs line 60 at r1 (raw file):

Previously, orizi wrote…

why not fixed-sized arrays and tuples as well?

Currently, we do not support partials of those anyway, and if I were to break them here, there is no code that's going to reconstruct them. We need to add specializationArg:{tuple,fixedsize, closure} for this to work.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

@TomerStarkware TomerStarkware added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit 559a4b0 Dec 11, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants