feat(react-bindings): add legacy client sdk support #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
statsig-kong bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
* feat(react-bindings): add legacy format support for server SDKs - Add useLegacyFormat parameter to useClientBootstrapInit - Conditionally call setDataLegacy when flag is enabled - Support legacy server SDKs that require separate user parameter Based on public PR #30 with naming feedback incorporated Co-Authored-By: [email protected] <[email protected]> * test(react-bindings): add comprehensive tests for useClientBootstrapInit - Test both standard bootstrap (setData) and legacy format (setDataLegacy) code paths - Verify correct parameter passing and method invocation - Ensure backward compatibility with default behavior - Follow existing test patterns from React bindings package Co-Authored-By: [email protected] <[email protected]> * fix: format test file with Prettier to resolve lint failure Co-Authored-By: [email protected] <[email protected]> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: [email protected] <[email protected]>
|
Thanks @kat-statsig - appreciate you getting this added! I noticed the release notes list you and devin as the authors. I’m guessing that’s automated? No worries either way, but if there’s a quick way to update it, it’d be great to have some creditfor this change. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Legacy Client Support to React Bindings SDK
Problem:
Currently, it's not possible to use the legacy client with the React Bindings SDK because the bootstrap initialisation always calls dataAdapter.setData(). However, Cloudflare integration requires using dataAdapter.setDataLegacy() method from the legacy Node SDK.
Solution:
Context:
Per discussion with Statsig: "I chatted with our SDK PM and they're still figuring out what the long-term plan will be for a server SDK on cloudflare. If they can get the new SDK running there it might be that, but for now the 'Legacy' Node SDK will be fully supported for cases like that, until we have a new solution."
This change enables developers using Cloudflare deployments to leverage the React bindings with the legacy Node SDK until a permanent solution is available.