Fix EventLogger process hangs in Node.js #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the client SDK is used on a server environment enabling event logging causes processes to hang indefintely. This is due to the `setInterval` call in `EventLogger` stopping Node.js from exiting. This diff adds a `Timeout::unref` call in the `EventLogger` so processes can exit normally. Events can be flushed by adding a `beforeExit` hook and handling termination. There might be another similar problem on the network code as trying to flush on a beforeExit hook also causes processes to hang.
yamadapc
commented
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the client SDK is used on a server environment enabling event logging causes processes to hang indefintely.
This is due to the
setIntervalcall inEventLoggerstopping Node.js from exiting.This diff adds a
Timeout::unrefcall in theEventLoggerso processes can exit normally.Events can be flushed by adding a
beforeExithook and handling termination. There might be another similar problem on the network code as trying to flush on a beforeExit hook also causes processes to hang.🧵 Slack thread