chore(ci): get rid of dirty flag #6677
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (21)
|
jakubgs
approved these changes
Jun 14, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6677 +/- ##
========================================
Coverage 59.77% 59.77%
========================================
Files 805 805
Lines 114125 114125
========================================
+ Hits 68213 68221 +8
+ Misses 38948 38918 -30
- Partials 6964 6986 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@siddarthkay do we still want this merged? Or should we close it? |
siddarthkay
force-pushed
the
cleanup-dirty-business
branch
2 times, most recently
from
7bb33fe to
46e9b2c
Compare
|
@igor-sirotin : still relevant, was just ignored by me for long. "dirty" has no business being in version and is often confusing when this version reaches status-desktop via status-go |
siddarthkay
changed the title
siddarthkay
force-pushed
the
cleanup-dirty-business
branch
from
46e9b2c to
b395b37
Compare
siddarthkay
force-pushed
the
cleanup-dirty-business
branch
from
b395b37 to
d165cf8
Compare
jakubgs
approved these changes
Oct 29, 2025
markoburcul
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found few instances of
--dirtyin status-go as well,Now that we don't have this versioning in status-desktop it would be consistent if we removed it from here as well.