Skip to content

Conversation

alexjba
Copy link
Contributor

@alexjba alexjba commented Oct 8, 2025

It seems to affect the new mobile app. Cannot login on failed sync because this workaround fails.

@status-im-auto
Copy link
Member

status-im-auto commented Oct 8, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 09bd263 #1 2025-10-08 14:14:58 ~3 min linux/status-go 📦zip
✔️ 09bd263 #1 2025-10-08 14:15:28 ~4 min macos/status-go 📦zip
✔️ 09bd263 #1 2025-10-08 14:19:44 ~8 min windows/status-go 📦zip
✔️ 09bd263 #1 2025-10-08 14:22:27 ~11 min tests-rpc 📄log
✔️ 09bd263 #1 2025-10-08 14:22:53 ~11 min linux/nwaku 📦zip
✔️ 09bd263 #1 2025-10-08 14:38:01 ~26 min tests 📄log
✔️ 5e38746 #2 2025-10-08 14:20:41 ~3 min macos/status-go 📦zip
✔️ 5e38746 #2 2025-10-08 14:21:27 ~4 min linux/status-go 📦zip
✔️ 5e38746 #2 2025-10-08 14:27:11 ~7 min windows/status-go 📦zip
✔️ 5e38746 #2 2025-10-08 14:33:23 ~10 min tests-rpc 📄log
✔️ 5e38746 #2 2025-10-08 14:33:40 ~10 min linux/nwaku 📦zip
✔️ 5e38746 #2 2025-10-08 15:05:13 ~27 min tests 📄log

It seems to affect the new mobile app. Cannot login on failed sync because this workaround fails.
@alexjba alexjba force-pushed the chore/clean-mobile-workaround branch from 09bd263 to 5e38746 Compare October 8, 2025 14:16
@alexjba alexjba changed the title chore_: Remove legacy mobile v1 migration workaround chore: Remove legacy mobile v1 migration workaround Oct 8, 2025
@alexjba alexjba marked this pull request as ready for review October 8, 2025 14:25
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.37%. Comparing base (c3bd89f) to head (5e38746).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6988      +/-   ##
===========================================
+ Coverage    55.13%   59.37%   +4.24%     
===========================================
  Files          820      821       +1     
  Lines       116624   116578      -46     
===========================================
+ Hits         64301    69221    +4920     
+ Misses       45535    40248    -5287     
- Partials      6788     7109     +321     
Flag Coverage Δ
functional 33.82% <ø> (?)
unit 55.10% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/geth_backend.go 51.61% <ø> (+2.23%) ⬆️

... and 214 files with indirect coverage changes

Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can drop all of v1-related migrations now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants