Skip to content

Conversation

@vkjr
Copy link
Contributor

@vkjr vkjr commented Oct 10, 2025

Description

This PR disables Mercuryo on-ramp for next old mobile release to prevent user dissatisfaction that Mecuryo doesn't work now. And to prevent any possible security issues.

Reviewer notes

Mobile takes the list of on-ramp providers from status-go and displays them in a list, this is why it is not disabled in mobile only.

@vkjr vkjr self-assigned this Oct 10, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Oct 10, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 48c5ffe #1 2025-10-10 14:52:38 ~3 min macos/status-go 📦zip
✔️ 48c5ffe #1 2025-10-10 14:52:59 ~3 min linux/status-go 📦zip
✔️ 48c5ffe #1 2025-10-10 14:54:46 ~5 min windows/status-go 📦zip
✔️ 48c5ffe #1 2025-10-10 15:00:19 ~11 min tests-rpc 📄log
✔️ 48c5ffe #1 2025-10-10 15:00:24 ~11 min linux/nwaku 📦zip
✔️ 48c5ffe #1 2025-10-10 15:16:26 ~27 min tests 📄log

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.22%. Comparing base (daef497) to head (48c5ffe).
⚠️ Report is 27 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6996      +/-   ##
===========================================
- Coverage    59.43%   59.22%   -0.22%     
===========================================
  Files          821      821              
  Lines       116626   116616      -10     
===========================================
- Hits         69315    69060     -255     
- Misses       40211    40433     +222     
- Partials      7100     7123      +23     
Flag Coverage Δ
functional 33.67% <ø> (-0.12%) ⬇️
unit 55.04% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
services/wallet/service.go 75.79% <ø> (-0.58%) ⬇️

... and 39 files with indirect coverage changes

Copy link
Collaborator

@igor-sirotin igor-sirotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could just set featureFlags.EnableMercuryoProvider = false?
Or if we want to remove it completely, perhaps we should remove everything related to it then?

@vkjr vkjr merged commit e061db0 into develop Oct 21, 2025
21 checks passed
@vkjr vkjr deleted the fix/remove-mercuryo-on-ramp-provider branch October 21, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants