chore: temporary change to see how tests behave with nwaku #7074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (6)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7074 +/- ##
===========================================
- Coverage 59.84% 54.92% -4.93%
===========================================
Files 803 810 +7
Lines 114133 115458 +1325
===========================================
- Hits 68305 63410 -4895
- Misses 38911 45344 +6433
+ Partials 6917 6704 -213
Flags with carried forward coverage won't be shown. Click here to find out more. |
Collaborator
|
All functional tests passed, which is weird in the assumption of light client not working 🤔 Looking at the logs, Seems that it's still |
Collaborator
|
Well... the docker build failed [2025-11-06T20:56:00.988Z] #15 117.1 �[92mBuilding:�[39m Nim compiler
[2025-11-06T20:58:57.509Z] #15 292.8 �[92mBuilding:�[39m install/usr/lib/libbacktrace.a
[2025-11-06T20:59:01.802Z] #15 297.0 �[92mBuilding:�[39m install/usr/lib/libbacktracenim.a
[2025-11-06T20:59:01.802Z] #15 297.0 �[92mBuilding:�[39m librln_v0.9.0.a
[2025-11-06T20:59:01.802Z] #15 297.1 ./scripts/build_rln.sh: line 18: rustc: command not found
[2025-11-06T20:59:01.802Z] #15 297.3 Failed to download -rln.tar.gz
[2025-11-06T20:59:01.802Z] #15 297.3 ./scripts/build_rln.sh: line 37: cargo: command not found
[2025-11-06T20:59:01.802Z] #15 297.3 make[1]: *** [Makefile:189: librln_v0.9.0.a] Error 127
[2025-11-06T20:59:01.802Z] #15 297.3 make[1]: Leaving directory '/go/src/github.com/status-im/nwaku'
[2025-11-06T20:59:01.802Z] #15 297.3 make: *** [Makefile:196: /go/src/github.com/status-im/status-go//../nwaku/build/libwaku.so] Error 2
[2025-11-06T20:59:01.802Z] #15 ERROR: process "/bin/sh -c make $build_target BUILD_TAGS=\"$build_tags\" BUILD_FLAGS=\"$build_flags\" GO_GENERATE_FAST_RECACHE=$([ \"$enable_go_cache\" = \"true\" ] && echo false || echo true) GO_GENERATE_FAST_DIR=\"/root/.cache/go-generate-fast\"" did not complete successfully: exit code: 2
[2025-11-06T20:59:01.802Z] ------
[2025-11-06T20:59:01.803Z] > [builder 9/9] RUN --mount=type=cache,target="/root/.cache/go-build",id=statusgo-build-local --mount=type=cache,target="/root/.cache/go-generate-fast",id=statusgo-build-local make cmd BUILD_TAGS="'gowaku_no_rln'" BUILD_FLAGS="-cover" GO_GENERATE_FAST_RECACHE=$([ "false" = "true" ] && echo false || echo true) GO_GENERATE_FAST_DIR="/root/.cache/go-generate-fast":
[2025-11-06T20:59:01.803Z] 117.1 �[92mBuilding:�[39m Nim compiler
[2025-11-06T20:59:01.803Z] 292.8 �[92mBuilding:�[39m install/usr/lib/libbacktrace.a
[2025-11-06T20:59:01.803Z] 297.0 �[92mBuilding:�[39m install/usr/lib/libbacktracenim.a
[2025-11-06T20:59:01.803Z] 297.0 �[92mBuilding:�[39m librln_v0.9.0.a
[2025-11-06T20:59:01.803Z] 297.1 ./scripts/build_rln.sh: line 18: rustc: command not found
[2025-11-06T20:59:01.803Z] 297.3 Failed to download -rln.tar.gz
[2025-11-06T20:59:01.803Z] 297.3 ./scripts/build_rln.sh: line 37: cargo: command not found
[2025-11-06T20:59:01.803Z] 297.3 make[1]: *** [Makefile:189: librln_v0.9.0.a] Error 127
[2025-11-06T20:59:01.803Z] 297.3 make[1]: Leaving directory '/go/src/github.com/status-im/nwaku'
[2025-11-06T20:59:01.803Z] 297.3 make: *** [Makefile:196: /go/src/github.com/status-im/status-go//../nwaku/build/libwaku.so] Error 2
[2025-11-06T20:59:01.803Z] ------
[2025-11-06T20:59:01.803Z] Dockerfile:30
[2025-11-06T20:59:01.803Z] --------------------
[2025-11-06T20:59:01.803Z] 29 | fi
[2025-11-06T20:59:01.803Z] 30 | >>> RUN --mount=type=cache,target="/root/.cache/go-build",id=statusgo-build-$cache_id \
[2025-11-06T20:59:01.803Z] 31 | >>> --mount=type=cache,target="/root/.cache/go-generate-fast",id=statusgo-build-$cache_id \
[2025-11-06T20:59:01.803Z] 32 | >>> make $build_target BUILD_TAGS="$build_tags" BUILD_FLAGS="$build_flags" \
[2025-11-06T20:59:01.803Z] 33 | >>> GO_GENERATE_FAST_RECACHE=$([ "$enable_go_cache" = "true" ] && echo false || echo true) \
[2025-11-06T20:59:01.803Z] 34 | >>> GO_GENERATE_FAST_DIR="/root/.cache/go-generate-fast"
[2025-11-06T20:59:01.803Z] 35 |
[2025-11-06T20:59:01.803Z] --------------------
[2025-11-06T20:59:01.803Z] ERROR: failed to build: failed to solve: process "/bin/sh -c make $build_target BUILD_TAGS=\"$build_tags\" BUILD_FLAGS=\"$build_flags\" GO_GENERATE_FAST_RECACHE=$([ \"$enable_go_cache\" = \"true\" ] && echo false || echo true) GO_GENERATE_FAST_DIR=\"/root/.cache/go-generate-fast\"" did not complete successfully: exit code: 2 |
igor-sirotin
force-pushed
the
validate-nwaku
branch
from
0de1e49 to
769f554
Compare
|
Thank you for opening this pull request! We require pull request titles and commits to follow the Conventional Commits specification and it looks like your PR needs to be adjusted. Details:
|
Collaborator
|
@Ivansete-status I've pushed a (temporal) change of |
Collaborator
|
In the first version, docker build failed (because of rust missing). But this was ignored by Fixed it here: |
Collaborator
|
Looks quite good, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to validate how tests behave when using nwaku