feat: introduce opentelemetry tracing #7172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (103)
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #7172 +/- ##
============================================
+ Coverage 34.81% 59.85% +25.03%
============================================
Files 797 815 +18
Lines 111054 113558 +2504
============================================
+ Hits 38662 67967 +29305
+ Misses 67502 38713 -28789
- Partials 4890 6878 +1988
Flags with carried forward coverage won't be shown. Click here to find out more.
|
osmaczko
force-pushed
the
chore/add-openeteletry-tracing
branch
2 times, most recently
from
b0adc28 to
1c09af3
Compare
osmaczko
changed the title
osmaczko
force-pushed
the
chore/add-openeteletry-tracing
branch
2 times, most recently
from
95f9fa0 to
eb110b2
Compare
osmaczko
changed the title
osmaczko
force-pushed
the
chore/add-openeteletry-tracing
branch
from
eb110b2 to
807239d
Compare
Collaborator
|
Seems that this PR includes changes from #7177 ? |
igor-sirotin
approved these changes
Dec 5, 2025
Collaborator
There was a problem hiding this comment.
I think this and README should live in /tools/opentelemetry
And internal/instrumentation/trace -> internal/trace
https://github.com/golang-standards/project-layout/tree/master/tools
WDYT?
Contributor
Author
There was a problem hiding this comment.
Hm.. examples given there are standalone tools, makes sense. I believe we should move some of our cmds to tools directory as well, e.g. cmd/generate-db, cmd/library.
Collaborator
There was a problem hiding this comment.
Yup, absolutely we should move some 💯
osmaczko
force-pushed
the
chore/add-openeteletry-tracing
branch
from
807239d to
936cc6b
Compare
jrainville
approved these changes
Dec 5, 2025
Member
jrainville
left a comment
jrainville
left a comment
There was a problem hiding this comment.
Very cool!
Just check the comment Igor made about the insta span end. I feel like it might be an oopsie
osmaczko
force-pushed
the
chore/add-openeteletry-tracing
branch
5 times, most recently
from
6def979 to
897c2a2
Compare
Required to derive trace context when a message has been segmented.
osmaczko
force-pushed
the
chore/add-openeteletry-tracing
branch
from
897c2a2 to
b47f7d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/status-im/status-go/blob/1c09af3e026fe4da56d375252eb17e5a69d2fe95/internal/instrumentation/README.md