WIP Added unary ops #14
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14 +/- ##
===========================================
+ Coverage 24.46% 36.19% +11.73%
===========================================
Files 8 10 +2
Lines 1206 1329 +123
===========================================
+ Hits 295 481 +186
+ Misses 911 848 -63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stemann
force-pushed
the
feature/unary_ops
branch
3 times, most recently
from
19ceee5 to
c681ce0
Compare
stemann
force-pushed
the
feature/unary_ops
branch
5 times, most recently
from
38e36c8 to
0e4de95
Compare
stemann
force-pushed
the
feature/unary_ops
branch
from
8d4ee5b to
985b215
Compare
stemann
commented
Apr 15, 2025
| element_types = MLX.supported_number_types(MLX.DeviceTypeGPU) # TODO Excluding Float64 | ||
|
|
||
| array_sizes = [ | ||
| # (), # TODO: Excluded broadcasting over 0-dimensional Array: Yields scalar result |
There was a problem hiding this comment.
Broadcasting over a zero-dimensional array returns a scalar and not a zero-dimensional array in current Julia: JuliaLang/julia#28866
stemann
force-pushed
the
feature/unary_ops
branch
3 times, most recently
from
41d3de5 to
d0b3311
Compare
stemann
force-pushed
the
feature/unary_ops
branch
2 times, most recently
from
c08af56 to
28ee04b
Compare
stemann
force-pushed
the
feature/unary_ops
branch
from
d2e62ce to
1e46f09
Compare
Also:
* Added necessary eval of MLX array data in Base.unsafe_convert(::Type{Ptr{T}}, array::MLXArray{T, N})
* Implemented Base.similar for MLXArray.
* Added supported_number_types(::DeviceType = DeviceTypeCPU)
* Workaround for sign on CPU for unsigned * Using Julia 1.10 compatible `ceil`, `floor`, and `round`: `ceil(T, x)` -> `T(ceil(x))`
stemann
force-pushed
the
feature/unary_ops
branch
from
1e46f09 to
7c062b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.