Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/MLX.jl
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module MLX

export MLXArray, MLXException, MLXMatrix, MLXVecOrMat, MLXVector
export MLXArray, MLXException, MLXMatrix, MLXString, MLXVecOrMat, MLXVector

include(joinpath(@__DIR__, "Wrapper.jl"))

Expand All @@ -9,6 +9,7 @@ include(joinpath(@__DIR__, "device.jl"))
include(joinpath(@__DIR__, "error_handling.jl"))
include(joinpath(@__DIR__, "metal.jl"))
include(joinpath(@__DIR__, "stream.jl"))
include(joinpath(@__DIR__, "string.jl"))

function __init__()
register_error_handler()
Expand Down
27 changes: 27 additions & 0 deletions src/string.jl
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
mutable struct MLXString <: AbstractString
mlx_string::Wrapper.mlx_string

function MLXString(ptr::Ptr{UInt8})
mlx_string = Wrapper.mlx_string_new_data(ptr)
this = new(mlx_string)
finalizer(d -> Wrapper.mlx_string_free(d.mlx_string), this)
return this
end
end

MLXString(str::AbstractString) = MLXString(pointer(str))

function Base.ncodeunits(str::MLXString)
return length(unsafe_string(Wrapper.mlx_string_data(str.mlx_string)))
end

function Base.iterate(str::MLXString)
return Base.iterate(unsafe_string(Wrapper.mlx_string_data(str.mlx_string)))
end
function Base.iterate(str::MLXString, i::Int)
return Base.iterate(unsafe_string(Wrapper.mlx_string_data(str.mlx_string)), i)
end

function convert(::Type{String}, str::MLXString)
return unsafe_string(Wrapper.mlx_string_data(str.mlx_string))
end
1 change: 1 addition & 0 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ using Test
if !Sys.iswindows() # Windows is hanging
include(joinpath(@__DIR__, "stream_tests.jl"))
end
include(joinpath(@__DIR__, "string_tests.jl"))
end
10 changes: 10 additions & 0 deletions test/string_tests.jl
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
using MLX
using Test

@testset "string" begin
@testset "constructor" begin
s = ""
s_mlx = MLXString(s)
@test s_mlx == s
end
end
Loading