Add support for embedding in-memory proto files into the parser #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stepancheg is it possible for you to look at this PR? our parser (https://github.com/cloudwego/pilota) relies heavily on this crate and it would really help if we could incorporate this feature into the official rust-protobuf without forking our own copy. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for embedding .proto files directly into the parser as in-memory strings. This is useful because it eliminates the need to always rely on filesystem-based inputs.
I Introduced a new method (add_custom_embedded) and field (custom_embedded) in the Parser struct which allowed .proto files to be directly added as (name, content) pairs via a HashMap<String, String>. These embedded files are then used by the pure parser during resolution if the file cannot be found on disk.