Skip to content

Conversation

Yuan-ManX
Copy link

No description provided.

@Anqw
Copy link
Collaborator

Anqw commented May 19, 2025

Hi @Yuan-ManX,

Thanks for the Pull Request!

I've reviewed it and found a couple of things that need addressing before this can be merged:

  1. SaveTexturedMesh needs to be an output node: Please add OUTPUT_NODE = True to the SaveTexturedMesh class definition. This is necessary for ComfyUI to recognize it as a valid endpoint for the workflow and prevent the "Prompt has no outputs" error.

  2. Missing subfolder argument in TexureSynthsis: The call to Step1X3DTexturePipeline.from_pretrained() within the TexureSynthsis node is missing the required subfolder argument. The current error is:
    TypeError: Step1X3DTexturePipeline.from_pretrained() missing 1 required positional argument: 'subfolder'
    Could you please update the call to include the subfolder argument?

Please push the changes to your branch once these are addressed. I'll review it again then.

Thanks for your contribution! Let me know if you have any questions.

@StepInfinite
Copy link
Collaborator

Hi, @Yuan-ManX , thanks for your contribution. Could you please fix the above prolem? Then, we will merge the ComfyUI to the main branch

@hyq2015
Copy link

hyq2015 commented Sep 19, 2025

Hello! I tried this ComfyUI integration @Yuan-ManX and applied your suggestion locally @Anqw, still got some issues, and I found there are some error in step1x3d_geometry/models/pipelines/pipeline.py, like TF is not defined, and below code:

elif isinstance(image, (torch.Tensor, PIL.Image.Image)): raise ValueError( "Input image must be atorch.TensororPIL.Image.Image." )

assert image.ndim == 3 (have to convert manually otherwise it was 4)

also with some import path issue

though I tried to fix them, I still got some new errors, so I really hope you can do a ComfyUI custom node officially, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants