[Fix] Update React hook useScroll
#71
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The React hook
useScrollcan incorrectly reflect the initialscrolledstate. This happens on first render, when the user's starting y-position is greater than thethreshold. The state reportsfalsewhen it should saytrue.Here, you can see we've started with a vertical scroll position beyond the threshold. As such, the
Navbarshould have a slightly opaque background; however, it's completely transparent.Solution
One way to fix this is by checking the user's initial y-position on first mount. We do that by invoking the
onScrollhandler when also registering it as a scroll event listener. That way, we don't rely on a scrolled event to correctly update the state. Note: it will always render asfalseon the server, but corrects itself immediately when the client first renders the component.Here, we see our solution implemented and
Navbarhas the background we'd expect.