ObligationScope should use references in Rails 4 when it uses includes. #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great and useful! |
|
+1 Trying to upgrade from rails 3 and running into this all over the place |
|
To elaborate further - The tables to include in the |
dgm
added a commit
to wested/declarative_authorization
that referenced
this pull request
Feb 25, 2016
Use references with includes to make sure the query doesn't fail
|
I believe this will fix my rails 4.1 problems. Thanks @aepstein |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Rails 4, includes would also outer join tables if query conditions referenced those tables. Rails 4 has dropped this behavior in favor of making the developer explicitly identify includes that must also be joined with an additional references() method on the scope. @zeiv modified tests to use references(), but it seems better to me to incorporate this directly into the scope() method of ObligationScope. This PR reverts the Rails 4-specific tests and instead sets references in Rails >= 4.