Skip to content

Added actionOpenClosed for contactSensors (simulated) #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Added actionOpenClosed for contactSensors (simulated) #154

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3a55950
Added actionOpenClosed for contactSensors (simulated)
iprak Jul 9, 2018
62dda1a
Don't add duplicate subscription
iprak Jan 17, 2019
05f5db7
Remove unused variable
iprak Jan 17, 2019
7a08fb4
Fixed white spaces
iprak Feb 2, 2019
bcd9c88
Only setting command if piece[2] is present and matches commandSuffix
iprak Aug 15, 2019
47165ad
Removed garageDoors entry since it has been deprecated in favor of do…
iprak Aug 15, 2019
6b6773e
Adjusted logging
iprak Dec 15, 2019
f3be0b9
Remove "switch" custom attribute from "Door Control", invoke action a…
iprak Dec 15, 2019
4b9fc5e
Removed capabilities for which I don't have any devices
iprak May 4, 2020
8aed2e1
Retry if connection fails
iprak Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,12 @@ function handleSubscribeEvent (req, res) {
subscriptions = [];
Object.keys(req.body.devices).forEach(function (property) {
req.body.devices[property].forEach(function (device) {
subscriptions.push(getTopicFor(device, property, TOPIC_COMMAND));
subscriptions.push(getTopicFor(device, property, TOPIC_WRITE_STATE));
var cmdTopic = getTopicFor(device, property, TOPIC_COMMAND);
var writeTopic = getTopicFor(device, property, TOPIC_WRITE_STATE);
subscriptions.push(cmdTopic);
if (writeTopic !== cmdTopic) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

subscriptions.push(writeTopic);
}
});
});

Expand Down Expand Up @@ -258,7 +262,6 @@ function parseMQTTMessage (topic, message) {
device = pieces[0],
property = pieces[1],
topicReadState = getTopicFor(device, property, TOPIC_READ_STATE),
topicWriteState = getTopicFor(device, property, TOPIC_WRITE_STATE),
topicSwitchState = getTopicFor(device, 'switch', TOPIC_READ_STATE),
topicLevelCommand = getTopicFor(device, 'level', TOPIC_COMMAND);

Expand Down
15 changes: 11 additions & 4 deletions smartapps/stj/mqtt-bridge.src/mqtt-bridge.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ import groovy.transform.Field
capability: "capability.contactSensor",
attributes: [
"contact"
]
],
action: "actionOpenClosed"
],
"doorControl": [
name: "Door Control",
Expand Down Expand Up @@ -611,11 +612,17 @@ def actionColor(device, attribute, value) {
}
}

//Action for contactSensors,doorControl,garageDoors,valve and windowShades.
//contactSensors don't have action but a simulated contact sensor can hence the hasCommand() check.
def actionOpenClosed(device, attribute, value) {
if (value == "open") {
device.open()
if (device.hasCommand("open")) {
device.open()
}
} else if (value == "closed") {
device.close()
if (device.hasCommand("close")) {
device.close()
}
}
}

Expand Down Expand Up @@ -721,4 +728,4 @@ def actionTimedSession(device, attribute, value) {
if (attribute == "timeRemaining") {
device.setTimeRemaining(value)
}
}
}