Add timer #59
Add timer #59
Conversation
| @@ -60,10 +60,14 @@ log-semihost = ["log"] | |||
| cortex-m = { version = "^0.7.7", features = ["critical-section-single-core"] } | |||
| stm32h5 = { package = "stm32h5", version = "0.16.0" } | |||
| fugit = "0.3.7" | |||
| embedded-hal-02 = { package = "embedded-hal", version = "0.2.6", features = ["unproven"] } | |||
There was a problem hiding this comment.
I don't think there's any reason to support embedded-hal 0.2 at this point. I've intentionally avoided doing so because embedded-hal 1.0 was released before any progress was made on this project.
| embedded-hal = "1.0.0" | ||
| defmt = { version = "1.0.0", optional = true } | ||
| paste = "1.0.15" | ||
| log = { version = "0.4.20", optional = true} | ||
| nb = "1.0.0" |
There was a problem hiding this comment.
I've avoided using the nb crate due to previous feedback that it's likely to be deprecated. See this thread: #27 (comment)
| //! - [Blinky using a Timer](https://github.com/stm32-rs/stm32h7xx-hal/blob/master/examples/blinky_timer.rs) | ||
| //! - [64 bit microsecond timer](https://github.com/stm32-rs/stm32h7xx-hal/blob/master/examples/tick_timer.rs) |
There was a problem hiding this comment.
There's a lot of mentions and links to stm32h7xx-hal in this file
| impl embedded_hal_02::timer::Periodic for Timer<$TIMX> {} | ||
|
|
||
| impl embedded_hal_02::timer::CountDown for Timer<$TIMX> { |
There was a problem hiding this comment.
As mentioned above, there's no need to support embedded-hal 0.2 in this crate, so we can remove these trait implementations (although we'll probably need to keep a similar start method)
| impl Timer<$TIMX> { | ||
| /// Configures a TIM peripheral as a periodic count down timer, | ||
| /// without starting it | ||
| pub fn $timX(tim: $TIMX, prec: rec::$Rec, clocks: &CoreClocks) -> Self |
There was a problem hiding this comment.
This shouldn't be public, as the expectation is that one uses the TIMX.timer(...) method to get a Timer instance.
| fn get_clk(clocks: &CoreClocks) -> Option<Hertz> { | ||
| Some(clocks.$ckX()) |
There was a problem hiding this comment.
No need to return an Option here as the clock, as stored in CoreClocks is not an optional. It will always be valid.
| embedded-hal = "1.0.0" | ||
| defmt = { version = "1.0.0", optional = true } | ||
| paste = "1.0.15" | ||
| log = { version = "0.4.20", optional = true} | ||
| nb = "1.0.0" | ||
| void = { version = "1.0.2", default-features = false } |
There was a problem hiding this comment.
this will be unnecessary with the embedded-hal 0.2 dependency removed
Copy code from stm32h7 to implement basic timer on stm32h5.
Add an example using Timer2: blinky_timer