-
Notifications
You must be signed in to change notification settings - Fork 116
https://issues.redhat.com/browse/ACM-21429 ClusterInstance field updates #8260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.15_stage
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dockerymick The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| |*reference* + | ||
| _required_|Specify dependencies or related objects in different namespaces.|array | ||
| |*namespace* + | ||
| _required_|Specify the namespace of the reference object.|string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share where you got these fields (viz. reference and namespace) from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sakhoury thanks for your patience! I was on PTO and catching up. Here is the link: https://github.com/stolostron/siteconfig/commit/a804ef8a4b8265f1469861c30a1c57a72489d413@
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dockerymick! Looks like we are missing the cpuArchitecture field defined here stolostron/siteconfig@269de14.
apis/clusterinstance.json.adoc
Outdated
| A cluster-level template consists of a `ConfigMap` object, in which the keys of the data field represent the kind of the installation manifests. | ||
| Cluster-level templates are instantiated once per cluster in the `ClusterInstance` CR.|array | ||
| |*hostRef* + | ||
| _optional_|Specify a refence to a `BareMetalHost` resource that is in a different resource.| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this description is missing key elements from the description in the ClusterInstance CRD:
// HostRef is a reference to a BareMetalHost node located in another namespace.
// It is used to link a resource to a specific BareMetalHost instance.
No description provided.