Skip to content

Conversation

@dockerymick
Copy link
Contributor

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dockerymick

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dockerymick dockerymick requested a review from sakhoury October 2, 2025 12:22
@dockerymick dockerymick changed the title https://issues.redhat.com/browse/ACM-21429 for 2.15 https://issues.redhat.com/browse/ACM-21429 ClusterInstance field updates Oct 9, 2025
Comment on lines +422 to +425
|*reference* +
_required_|Specify dependencies or related objects in different namespaces.|array
|*namespace* +
_required_|Specify the namespace of the reference object.|string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share where you got these fields (viz. reference and namespace) from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakhoury thanks for your patience! I was on PTO and catching up. Here is the link: https://github.com/stolostron/siteconfig/commit/a804ef8a4b8265f1469861c30a1c57a72489d413@

Copy link
Contributor

@sakhoury sakhoury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dockerymick! Looks like we are missing the cpuArchitecture field defined here stolostron/siteconfig@269de14.

A cluster-level template consists of a `ConfigMap` object, in which the keys of the data field represent the kind of the installation manifests.
Cluster-level templates are instantiated once per cluster in the `ClusterInstance` CR.|array
|*hostRef* +
_optional_|Specify a refence to a `BareMetalHost` resource that is in a different resource.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this description is missing key elements from the description in the ClusterInstance CRD:

// HostRef is a reference to a BareMetalHost node located in another namespace.
// It is used to link a resource to a specific BareMetalHost instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants